Merged
Conversation
- 챌린지 모드에서는 챌린지 관련 값이 필수 - 목표 모드에서는 목표 관련 값이 필수
- requestV2 추가 - 러닝 경로 공통 응답, 요쳥 형식 DTO 추가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 이슈 연결
🚀 구현한 API
💡 반영할 내용 및 변경 사항 요약
🔍 리뷰 요청/참고 사항
RunningResultDto를 추가했습니다. 러닝 결과 조회 시 해당 Dto를 사용할 예정입니다. 데이터 가공은 각 프레젠테이션 계층에서 진행됩니다.com.dnd.runus.presentation.v1.running.dto.request에 있는 RunningAchievementMode는 변경 가능성이 매우 작고, 다른 버전에서 공통으로 사용되며, 서비스 계층에서도 사용되어서 해당 클래스를com.dnd.runus.application.running.dto패키지로 옮겨서 사용하는 건 어떻게 생각하는지 궁금합니다.