Feat : Portal, Popup창 구현 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seondal
approved these changes
Aug 5, 2023
| @@ -15,6 +15,7 @@ | |||
| "@types/react-dom": "18.2.7", | |||
| "eslint": "^8.46.0", | |||
| "eslint-config-next": "^13.4.12", | |||
| "framer-motion": "^10.15.0", | |||
There was a problem hiding this comment.
라이브러리를 사용하셨군요..! Bottom Sheet 구현시에도 필요하다면 사용해보겠습니답
Comment on lines
+17
to
+22
| document.addEventListener('mousedown', listener); | ||
| document.addEventListener('touchstart', listener); | ||
|
|
||
| return () => { | ||
| document.removeEventListener('mousedown', listener); | ||
| document.removeEventListener('touchstart', listener); |
There was a problem hiding this comment.
return 문 밖에 있는 코드와 안에 있는 코드 사이의 차이가 있을까요 ?
There was a problem hiding this comment.
useEffect의 첫 번째인자인 콜백함수의 내부함수는 mount될 때 실행됩니다. 그리고, return문의 함수는 unmount될 때 실행됩니다.
그래서, 위 코드에서는 컴포넌트가 mount되었을 때 이벤트가 추가되고, unmount될 때 이벤트가 제거 되며 이벤트를 cleanup해줍니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
💬 리뷰어분들께
자유롭게 해주세용 ~