Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy over hooks from base schema #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vkarpov15
Copy link

Hi,

Thanks for the elegant lib! You're missing support for a couple things though, like copying hooks from the base schema (Automattic/mongoose#5897) .

An alternative implementation would be to do:

function extendSchema(schema, definition) {
  var clone = schema.clone();
  schema.add(definition);
  return schema;
}

This will copy over hooks and everything else, like plugins, query methods, statics, etc. Any thoughts on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant