Skip to content

Rename "Example" tests to satisfy Go 1.24's new vet rule #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Rename "Example" tests to satisfy Go 1.24's new vet rule #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/gitfs/tarscrub_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (

// this example is nice because it has some intentionally dangling symlinks in it that trip things up if they aren't implemented correctly!
// (see also pkg/tarscrub/git_test.go)
func ExampleGitVarnish() {
func Example_gitVarnish() {
repo, err := git.Clone(memory.NewStorage(), nil, &git.CloneOptions{
URL: "https://github.com/varnish/docker-varnish.git",
SingleBranch: true,
Expand Down Expand Up @@ -46,7 +46,7 @@ func ExampleGitVarnish() {
// this example is nice because it has a different committer vs author timestamp
// https://github.com/tianon/docker-bash/commit/eb7e541caccc813d297e77cf4068f89553256673
// https://github.com/docker-library/official-images/blob/8718b8afb62ff1a001d99bb4f77d95fe352ba187/library/bash
func ExampleGitBash() {
func Example_gitBash() {
repo, err := git.Clone(memory.NewStorage(), nil, &git.CloneOptions{
URL: "https://github.com/tianon/docker-bash.git",
SingleBranch: true,
Expand Down
4 changes: 2 additions & 2 deletions pkg/tarscrub/git_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"github.com/go-git/go-git/v5/storage/memory"
)

func ExampleGitHello() {
func Example_gitHello() {
repo, err := git.Clone(memory.NewStorage(), nil, &git.CloneOptions{
URL: "https://github.com/docker-library/hello-world.git",
SingleBranch: true,
Expand Down Expand Up @@ -43,7 +43,7 @@ func ExampleGitHello() {

// this example is nice because it has some intentionally dangling symlinks in it that trip things up if they aren't implemented correctly!
// (see also pkg/gitfs/tarscrub_test.go)
func ExampleGitVarnish() {
func Example_gitVarnish() {
repo, err := git.Clone(memory.NewStorage(), nil, &git.CloneOptions{
URL: "https://github.com/varnish/docker-varnish.git",
SingleBranch: true,
Expand Down
Loading