Add krakend official image

[alombarte]

Hi there,

We are currently whitelisted as open-source contributors, and we would also like to add our KrakenD image to the official list.

Thanks!

[tianon]

I'm frankly very confused here by several things 🙈 😇

"We are currently whitelisted as open-source contributors" isn't a familiar phrase for me, so I'd love to hear more details on what exactly that means to you and/or the krakend project?

luraproject/lura#488 (merged by a familiar face 👀) makes me wonder if it really makes sense to make a "krakend" image if it's going to be (has been for months??) renamed to "lura" ? What's the deal with https://www.krakend.io/ (no mention of Lura there I can find) ?

What's the relationship between @devopsfaith and the krakend / lura project/community? What is "krakend-ce" ? 😬

[alombarte]

Hi @tianon ,

Thanks for your quick response. I understand why you are confused, 😂 I will explain, no worries. The easy part: By whitelisted, I mean that we are already in the Open Source Program (and we are whitelisted for the data pull rate restrictions).

All these different names you are mentioning are things we drag from our history. @devopsfaith started as a group where some friends were creating projects for fun, and took a random name. KrakenD was hosted there in 2016 as one of the projects (there were also things like api2html). The @devopsfaith it will eventually disappear, and all repos transferred to the new @krakendio to precisely avoid this confusion.

Lura is to KrakenD similarly what Moby is to Docker. There is no Lura ready-to-use image, as it is an API gateway toolkit/libraries to build your own gateway. Lura was originally the "KrakenD framework" (KrakenD's engine) and donated recently to the Linux Foundation (press note). You can still see 302 the redirection to Lura here.

KrakenD CE was a distinction between the framework and the Community Edition (CE-). But today, when we talk about KrakenD, we are referring to the repo krakend-ce.

You probably have more questions, and I will be happy to answer, but let me do one to me. Why our Business Director @obokaman-com looks familiar to you? I am curious about it.

[alombarte]

Hi @tianon ,

Is there anything else I can help you with? Do not hesitate to ask.
Thanks for your review!

[ksylvan]

What is happening with this? It's been a while.

[yosifkit]

close/reopen to trigger GitHub actions once again

[tianon]

Some of these things build on what I've just written in docker-library/official-images#13592 (comment), so I recommend starting there. This is all really minor stuff, though. 👍

[tianon]

These should not be indented and code-fenced, and if you want to use console as the highlight, you'll want to add the "prompt" sigil ($); alternatively, you could switch to bash:

Suggested change

	```console
	docker run -p 8080:8080 -v "${PWD}:/etc/krakend/" %%IMAGE%% run -d -c /etc/krakend/krakend.json
	```
	```console
	$ docker run -p 8080:8080 -v "${PWD}:/etc/krakend/" %%IMAGE%% run -d -c /etc/krakend/krakend.json
	```

or:

Suggested change

	```console
	docker run -p 8080:8080 -v "${PWD}:/etc/krakend/" %%IMAGE%% run -d -c /etc/krakend/krakend.json
	```
	```bash
	docker run -p 8080:8080 -v "${PWD}:/etc/krakend/" %%IMAGE%% run -d -c /etc/krakend/krakend.json
	```

[tianon]

See above.

[tianon]

This should be consistent too (and this one in particular probably ought to include --rm).

[tianon]

As I noted in the review on the Dockerfile, I think this gets cleaner for users if you lean into the WORKDIR:

Suggested change

	COPY krakend.json /etc/krakend/krakend.json
	# Check and test that the file is valid
	RUN krakend check -d -t -c /etc/krakend/krakend.json
	COPY krakend.json ./
	# Check and test that the file is valid
	RUN krakend check -d -t -c krakend.json

(although this is one that's up to you)

[tianon]

As noted in the other review, I would suggest not marrying yourself explicitly to su-exec:

Suggested change

	All `krakend` commands are executed as `krakend` user (uid=1000) through `su-exec`, and the rest of the commands (e.g., `sh`) are executed as root.
	All `krakend` commands are executed as `krakend` user (uid=1000), and the rest of the commands (e.g., `sh`) are executed as root.

[tianon]

Again, you probably ought to use a fenced code block here with either console or bash (and add the prompt or not as appropriate), and with help as the example, --rm is appropriate to include.

[tianon]

(It would also be helpful if you squash your commits, particularly the merge commits.)

[tianon]

(force pushed a rebase+squash and the newline-at-EOL markdownfmt fix)

[alombarte]

Thank you @tianon!