Skip to content

Commit

Permalink
Improve CI experience
Browse files Browse the repository at this point in the history
Signed-off-by: David Young <[email protected]>
  • Loading branch information
funkypenguin committed Apr 26, 2020
1 parent 29afd00 commit 5e4b991
Show file tree
Hide file tree
Showing 6 changed files with 41 additions and 7 deletions.
7 changes: 7 additions & 0 deletions .ci/ct-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# This file defines the config for "ct" (chart tester) used by the helm linting GitHub workflow

# Here we define every possible upstream repo our charts use in `requirements.yaml`
chart-repos:
- haproxy=https://haproxytech.github.io/helm-charts

lint-conf: .ci/lint-config.yaml
6 changes: 6 additions & 0 deletions .ci/lint-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
rules:
# One blank line is OK
empty-lines:
max-start: 1
max-end: 1
max: 1
3 changes: 3 additions & 0 deletions .ci/scripts/local-ci.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/bash

docker run --rm -it -w /repo -v `pwd`:/repo quay.io/helmpack/chart-testing ct lint --config=.ci/ct-config.yaml
22 changes: 22 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# :wave: How can I contribute?

First off, thank you for helping to improve this chart! :heart_eyes: :pray:

## Testing

To test the chart locally, before submitting changes, run `./ci/scripts/local-ci.sh`

## Submitting changes

Please send a [GitHub Pull Request](https://github.com/funkypenguin/helm-docker-mailserver/pull/new/master) with a clear list of what you've done (read more about [pull requests](http://help.github.com/pull-requests/)).

When you send a pull request, please make sure all of your commits are atomic (one feature per commit), and bump the chart version in `chart.yaml`

Always write a clear log message for your commits. One-line messages are fine for small changes, but bigger changes should look like this:

$ git commit -m "A brief summary of the commit
>
> A paragraph describing what changed and its impact."

Thanks again!
Funky Penguin :penguin:
6 changes: 3 additions & 3 deletions charts/docker-mailserver/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ apiVersion: v1
appVersion: "6.3.0"
description: A fullstack but simple mailserver (smtp, imap, antispam, antivirus, ssl...) using Docker.
name: docker-mailserver
version: 0.2.3
version: 0.2.4-pre1
sources:
- https://github.com/funkypenguin/docker-mailserver
- https://github.com/funkypenguin/helm-docker-mailserver
maintainers:
- name: funkypenguin
email: [email protected]
Expand All @@ -14,4 +14,4 @@ keywords:
- dovecot
- amavis
- imap
tillerVersion: ">=2.13.0"
home: https://github.com/funkypenguin/helm-docker-mailserver
4 changes: 0 additions & 4 deletions charts/docker-mailserver/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ initContainer:
## it may terminated.
memory: "64Mi"



serviceAccount:
create: "true"

Expand Down Expand Up @@ -318,8 +316,6 @@ monitoring:
path: "/metrics"
## Port on which HTTP server is served
port: "9102"



# Values imported from https://github.com/t13a/helm-chart-rainloop/blob/master/values.yaml
rainloop:
Expand Down

0 comments on commit 5e4b991

Please sign in to comment.