This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
[WIP] Utilized public fossa-analyzer image #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zuhayr Elahi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
==========================================
- Coverage 72.73% 72.05% -0.68%
==========================================
Files 50 49 -1
Lines 2648 2559 -89
==========================================
- Hits 1926 1844 -82
+ Misses 486 484 -2
+ Partials 236 231 -5
Continue to review full report at Codecov.
|
ndeloof
suggested changes
Sep 18, 2019
Jenkinsfile.baguette
Outdated
| string(credentialsId: 'fossa-api-key', variable: 'FOSSA_API_KEY') | ||
| ]) { | ||
| dir('src/github.com/docker/app') { | ||
| checkout scm | ||
| ansiColor('xterm') { | ||
| sh "docker login -u $REGISTRY_USERNAME -p $REGISTRY_PASSWORD" | ||
| sh "FOSSA_API_KEY=$FOSSA_API_KEY BRANCH_NAME='${BRANCH_NAME}' make fossa-analyze" |
There was a problem hiding this comment.
unnecessary. withCredentials already expose FOSSA_API_KEY environment variable
Signed-off-by: Zuhayr Elahi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zuhayr Elahi [email protected]
- What I did
Utilized the public fossa-analyzer image on hub
- How I did it
changed the references and removed calls to
dockereng- How to verify it
I ran the
fossa-analyzeandfossa-testlocallyAlso double checking it works as expected in the CI
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)