This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
[WIP] Add support for secrets #671
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Sirot <[email protected]>
jcsirot
force-pushed
the
handle-secrets-secure-params
branch
from
52ddb49
to
c8d3cb0
Compare
| @@ -108,6 +108,20 @@ func ToCNAB(app *types.App, invocationImageName string) (*bundle.Bundle, error) | |||
| Definition: name, | |||
| } | |||
| } | |||
| for name, secret := range app.Secrets() { | |||
| writeOnly := new(bool) | |||
There was a problem hiding this comment.
I think the following code is simpler:
writeOnly := true
definitions[internal.SecretsParameterPrefix+name] = &definition.Schema{
Type: "string",
WriteOnly: &writeOnly,
}|
|
||
| // New creates a new empty secret map | ||
| func New() Secrets { | ||
| return make(map[string]Secret) |
There was a problem hiding this comment.
nit: You can also use the defined type return make(Secrets)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Ensure that secrets defined in the Compose file are correctly handled by Docker App and the CNAB bundle.
- How I did it
TBD
- How to verify it
TBD
- Description for the changelog
TBD
- A picture of a cute animal (not mandatory but encouraged)
