Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Add service image build example #723

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chris-crone
Copy link
Member

- What I did
Added an example of a Docker App that has service images that can be built.

- Description for the changelog
N/A

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #723 into master will decrease coverage by 1.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   72.45%   70.99%   -1.46%     
==========================================
  Files          59       59              
  Lines        3438     3031     -407     
==========================================
- Hits         2491     2152     -339     
+ Misses        612      588      -24     
+ Partials      335      291      -44
Impacted Files Coverage Δ
internal/commands/run.go 60.22% <0%> (-9.86%) ⬇️
internal/commands/remove.go 52% <0%> (-8.57%) ⬇️
internal/store/bundle.go 68.93% <0%> (-7.75%) ⬇️
internal/commands/update.go 58.18% <0%> (-7.21%) ⬇️
internal/cnab/cnab.go 63.33% <0%> (-6.24%) ⬇️
internal/commands/image/list.go 83.33% <0%> (-5.82%) ⬇️
types/parameters/parameters.go 93.65% <0%> (-3.18%) ⬇️
internal/commands/push.go 45.22% <0%> (-2.57%) ⬇️
internal/commands/image/tag.go 88.88% <0%> (-1.31%) ⬇️
internal/store/digest.go 86.36% <0%> (-0.82%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6267dc4...6bc0a3f. Read the comment docs.

Signed-off-by: Christopher Crone <[email protected]>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

description:
# List of application maintainers with name and email for each
maintainers:
- name: chris
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware, you'll have to maintain this app! 🧌

@chris-crone
Copy link
Member Author

I still need to add a readme for this so will leave it in draft until that's done.

@ndeloof
Copy link
Contributor

ndeloof commented Nov 7, 2019

https://github.com/docker/app/tree/master/examples/voting-app is already such a docker app build sample, maybe it should have better documentation to make it visible ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants