controller: remove controller grpc service #3126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
controller-removal
branch
from
a352c85 to
94c0b4f
Compare
jsternberg
force-pushed
the
controller-removal
branch
from
94c0b4f to
c6172f7
Compare
jsternberg
changed the title
jsternberg
force-pushed
the
controller-removal
branch
from
c6172f7 to
3482c46
Compare
jsternberg
force-pushed
the
controller-removal
branch
2 times, most recently
from
3b3a507 to
7b11d17
Compare
jsternberg
force-pushed
the
controller-removal
branch
from
7b11d17 to
e6a8344
Compare
jsternberg
force-pushed
the
controller-removal
branch
from
e6a8344 to
753545e
Compare
Remove the controller grpc service along with associated code related to sessions or remote controllers. Data types that are still used with complicated dependency chains have been kept in the same package for a future refactor. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
controller-removal
branch
from
753545e to
2f1be25
Compare
tonistiigi
approved these changes
May 1, 2025
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
This seems like a good first step towards #3124. I tested the debug command/monitor manually and all local commands still seemed to work as expected.
Looks like errdefs proto could have also been removed directly with this, but that can be the next PR.
Member
|
BSD error is unrelated. Looks like another change in the vagrant vm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the controller grpc service along with associated code related to
sessions or remote controllers.
Data types that are still used with complicated dependency chains have
been kept in the same package for a future refactor.
Fixes #3124.