build: fix segfault with nil refs in multi-platform target dependencies #3514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building multi-platform images with bake where target contexts reference other targets, a segmentation fault occurred when calling ToState() on nil references in the Refs map. This occurs with platform-independent builds (e.g., "FROM scratch") where BuildKit optimizes by not materializing separate references for identical content across platforms, resulting in nil entries in the Refs map. The fix adds a nil check to skip nil references, consistent with how BuildKit's own code handles such cases. Fixes docker#3508 Signed-off-by: GitHub Copilot <[email protected]> Signed-off-by: Orgad Shaneh <[email protected]>
orgads
force-pushed
the
scratch-multiarch-crash
branch
from
71fe24c to
3d4ec3a
Compare
Author
|
@tonistiigi Sorry, I didn't notice you already pushed #3511. Thanks! You can grab the test if you want :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building multi-platform images with bake where target contexts reference other targets, a segmentation fault occurred when calling ToState() on nil references in the Refs map.
This occurs with platform-independent builds (e.g., "FROM scratch") where BuildKit optimizes by not materializing separate references for identical content across platforms, resulting in nil entries in the Refs map.
The fix adds a nil check to skip nil references, consistent with how BuildKit's own code handles such cases.
Fixes #3508