build: split out node resolver #3551
Merged
+81
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
split-node-resolver
branch
from
5a4ec6b to
3e413a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply splits out the node resolver into a separate sub-package.
I wanted to use the
resolveDriversfunction in some code that interfaces withbuildxby importing it. It's useful to access the same logic for booting and platform matching that buildx itself uses (since some platform info is only available once the node is booted).While the
builderanddriverspackage are easily importable, thebuildpackage depends on the entire AWS SDK. Splitting the resolver out into it's own package makes the code more reusable, and also hopefully makes it easier to refactor long-term.