Enable completion for docker images
#6452
Conversation
doringeman
force-pushed
the
image-list-completions
branch
from
7672399 to
0fdbc75
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
doringeman
force-pushed
the
image-list-completions
branch
from
0fdbc75 to
f3f88ae
Compare
cli/command/completion/functions.go
Outdated
| names = append(names, baseName) | ||
| } | ||
| } | ||
| return names, cobra.ShellCompDirectiveNoSpace |
There was a problem hiding this comment.
This still needs the ShellCompDirectiveNoFileComp to avoid completing files when there's no images
| return names, cobra.ShellCompDirectiveNoSpace | |
| return names, cobra.ShellCompDirectiveNoSpace | ShellCompDirectiveNoFileComp |
There was a problem hiding this comment.
Also, wondering if the NoSpace is even needed if we have both the base name (like alpine) and the individual tags (alpine:latest, alpine:3.20, ...).
There was a problem hiding this comment.
I added NoSpace so I can select the base name and then continue seeing it with all the tags. There are no completing files if I'm using NoSpace.
There was a problem hiding this comment.
But if there are no images, then NoSpace alone would still show files. (at least that's what I'm seeing with fish)
There was a problem hiding this comment.
Oh, OK, TIL! Updated. Thank you!
Signed-off-by: Dorin Geman <[email protected]>
doringeman
force-pushed
the
image-list-completions
branch
from
f3f88ae to
74d0210
Compare
| for _, img := range list { | ||
| names = append(names, img.RepoTags...) | ||
| for _, tag := range img.RepoTags { | ||
| if baseName, _, ok := strings.Cut(tag, ":"); ok { |
There was a problem hiding this comment.
This could use the reference.Parse* function... Otherwise it will produce truncated image names for images on repos using non-standard port like localhost:5000/myimage:latest
- What I did
Enabled completion for
docker images.- How I did it
By adding a new
ImageNamesWithBasecompletion function which offers completion for images present within the local store, including both full image names with tags and base image names (repository names only) when multiple tags exist for the same base name.- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
Source: https://earth.org/world-lemur-day/.