vendor: github.com/moby/moby/api, moby/moby/client master #6576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
robmry
force-pushed
the
bump_modules_again
branch
3 times, most recently
from
7361ea6 to
de926ca
Compare
thaJeztah
reviewed
Oct 26, 2025
cli/command/container/inspect.go
Outdated
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| return &res.Container, nil, nil |
Member
There was a problem hiding this comment.
Suggested change
| return &res.Container, nil, nil | |
| return &res.Container, res.Raw, nil |
robmry
force-pushed
the
bump_modules_again
branch
from
de926ca to
8a67307
Compare
thaJeztah
reviewed
Oct 27, 2025
Comment on lines
+169
to
+175
| var cs client.ConsoleSize | ||
| if execOptions.ConsoleSize != nil { | ||
| cs = client.ConsoleSize{ | ||
| Height: execOptions.ConsoleSize[0], | ||
| Width: execOptions.ConsoleSize[1], | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I'll have a look in a follow-up to see if we actually still need the locally defined execOptions struct / type, or if it has all the same fields as client.ExecAttachOptions (so possibly we could use that one direct).
Signed-off-by: Rob Murray <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
bump_modules_again
branch
from
8a67307 to
4a60806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)