cli/command/container: use ImagePull instead of ImageCreate #6597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vvoland
reviewed
Oct 31, 2025
cli/command/container/client_test.go
Outdated
|
|
||
| type fakeStreamResult struct { | ||
| io.ReadCloser | ||
| client.ImagePushResponse // same interface as [client.ImagePullResponse] |
Collaborator
There was a problem hiding this comment.
Oh, just noticed client.ImagePushResponse doesn't follow the "XXXResult" pattern (Response vs Result)
Member
Author
There was a problem hiding this comment.
oh! yes, you're right! I think I noticed that, but then forgot.
Looks like I picked the wrong one here (well, they're the same, but perhaps better to pick pull as we're using it for pull here.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
use_pull_for_pull
branch
from
cef9947 to
7bdb4df
Compare
vvoland
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)