Skip to content

Conversation

@thaJeztah
Copy link
Member

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah force-pushed the remove_trust_integration branch 2 times, most recently from e1ea736 to f4655e0 Compare October 31, 2025 21:35
@thaJeztah thaJeztah added this to the 29.0.0 milestone Oct 31, 2025
@thaJeztah thaJeztah force-pushed the remove_trust_integration branch from 82328d1 to d5c84fa Compare October 31, 2025 21:57
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 58.49057% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/manifest/annotate.go 0.00% 15 Missing ⚠️
cli/command/image/pull.go 58.33% 4 Missing and 1 partial ⚠️
cli/command/plugin/push.go 0.00% 1 Missing ⚠️
internal/registryclient/client.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah force-pushed the remove_trust_integration branch 3 times, most recently from a8da549 to c3ae4cb Compare November 3, 2025 13:11
@thaJeztah thaJeztah force-pushed the remove_trust_integration branch from c3ae4cb to 8cc9839 Compare November 3, 2025 13:17
@thaJeztah thaJeztah force-pushed the remove_trust_integration branch from 8cc9839 to ad776d1 Compare November 3, 2025 13:24
@thaJeztah thaJeztah marked this pull request as ready for review November 3, 2025 13:52
@thaJeztah thaJeztah requested a review from a team as a code owner November 3, 2025 13:52
Comment on lines +84 to +87
// TODO(thaJeztah): Are these expected to be included?
Auth: a.Auth,
IdentityToken: a.IdentityToken,
RegistryToken: a.RegistryToken,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at these soon!

@thaJeztah
Copy link
Member Author

Thanks! Let's bring this one in 👍

@thaJeztah thaJeztah merged commit c01696f into docker:master Nov 4, 2025
106 of 107 checks passed
@thaJeztah thaJeztah deleted the remove_trust_integration branch November 4, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants