Skip to content

ci: run integration tests on forks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sayt-0 merged 8 commits into from
Jun 16, 2026
Merged

ci: run integration tests on forks #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cf28a5e
ci: use pull_request_target so fork PRs receive secrets in E2E tests
derekmisler Jun 15, 2026
3eaa71d
ci: bump raven-actions/actionlint to v2.1.2 to fix npm install failure
derekmisler Jun 15, 2026
6db57cd
ci: fix empty ref on push events — use pr.head.sha || github.sha
derekmisler Jun 15, 2026
f9fcf87
ci: replace raven-actions/actionlint with direct go install
derekmisler Jun 15, 2026
b100e93
ci: disable shellcheck in direct actionlint invocation to match prior…
derekmisler Jun 15, 2026
f7d22eb
ci: revert to pull_request trigger, remove ref: overrides
derekmisler Jun 15, 2026
87741f6
ci: revert test.yml — actionlint workaround out of scope
derekmisler Jun 15, 2026
ed16a4a
Merge branch 'main' into fix/fork-pr-e2e-secrets
derekmisler Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 12 additions & 67 deletions .github/workflows/test-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
name: Test Docker Agent Action

on:
pull_request:
pull_request_target:
Comment thread
derekmisler marked this conversation as resolved.
Outdated
types: [opened, synchronize, reopened]
branches: [main]
push:
Expand Down Expand Up @@ -56,41 +56,26 @@ jobs:
permissions:
contents: read
steps:
- name: Check if fork PR

@docker-agent docker-agent Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Fork-detection guards removed from test-pirate-agent — dangerous step toward pwn-request if trigger changes

This PR removes the "Check if fork PR" step and all if: steps.fork-check.outputs.is_fork != 'true' conditions from test-pirate-agent. While the current pull_request trigger means fork PRs already receive empty secrets (GitHub's built-in protection), the PR description explicitly states the intent to switch to pull_request_target.

Under pull_request_target + checkout of github.event.pull_request.head.sha + uses: ./, this guard was the only step-level protection against a fork contributor executing their own code with live OPENAI_API_KEY credentials. After this deletion, there is no step-level, job-level, or environment-level gate remaining on this job.

This creates a single-commit path to a critical secret exfiltration vulnerability: applying the stated pull_request_target trigger change without adding new guards would allow any fork PR to run arbitrary action.yml / dist/*.js code with live API keys.

Suggested mitigation: Before or alongside the trigger change, add either:

  1. A job-level guard: if: github.event.pull_request.head.repo.full_name == github.repository || github.event_name != 'pull_request_target'
  2. A GitHub Environment with required reviewers on this job

id: fork-check
run: |
# Use default empty string to handle edge cases (deleted branches, malformed events)
HEAD_REPO="${{ github.event.pull_request.head.repo.full_name || '' }}"
if [[ "${{ github.event_name }}" == "pull_request" && "$HEAD_REPO" != "${{ github.repository }}" && -n "$HEAD_REPO" ]]; then
echo "⏭️ Skipping - fork PR (secrets not available)"
echo "is_fork=true" >> $GITHUB_OUTPUT
else
echo "is_fork=false" >> $GITHUB_OUTPUT
fi

- name: Checkout code
if: steps.fork-check.outputs.is_fork != 'true'
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
ref: ${{ github.event.pull_request.head.sha }}
Comment thread
derekmisler marked this conversation as resolved.
Outdated

- name: Setup pnpm
if: steps.fork-check.outputs.is_fork != 'true'
uses: pnpm/action-setup@8912a9102ac27614460f54aedde9e1e7f9aec20d # v6.0.5
with:
run_install: false

- name: Setup Node.js
if: steps.fork-check.outputs.is_fork != 'true'
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 24
cache: pnpm

- name: Build action
if: steps.fork-check.outputs.is_fork != 'true'
run: pnpm install --frozen-lockfile && pnpm build

- name: Run test
Comment thread
derekmisler marked this conversation as resolved.
if: steps.fork-check.outputs.is_fork != 'true'

@docker-agent docker-agent Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] uses: ./ step in test-pirate-agent loses its fork guard — unguarded under pull_request_target

The if: steps.fork-check.outputs.is_fork != 'true' condition is removed from the "Run test" step, which executes the composite action from the local checkout (uses: ./) and passes openai-api-key: ${{ secrets.OPENAI_API_KEY }}.

Today (with pull_request trigger): secrets are empty for fork PRs — no immediate leak.
After the stated trigger change to pull_request_target: a fork contributor controls the checked-out action.yml and dist/*.js files that this step executes, and secrets.OPENAI_API_KEY is a live key.

Note that uses: ./ runs the fork's version of the action — even without the API key, a fork contributor can modify the composite action to leak GITHUB_TOKEN or perform other attacks using the runner's contents: read permission.

id: pirate
uses: ./
with:
Expand All @@ -99,7 +84,6 @@ jobs:
openai-api-key: ${{ secrets.OPENAI_API_KEY }}

- name: Validate output and exit code
if: steps.fork-check.outputs.is_fork != 'true'
run: |
OUTPUT_FILE="${{ steps.pirate.outputs.output-file }}"

Expand Down Expand Up @@ -153,6 +137,8 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Setup pnpm
uses: pnpm/action-setup@8912a9102ac27614460f54aedde9e1e7f9aec20d # v6.0.5
Expand Down Expand Up @@ -205,45 +191,27 @@ jobs:
env:
TEST_PR_NUMBER: ${{ github.event.pull_request.number || inputs.pr_number }}
steps:
- name: Check if fork PR

@docker-agent docker-agent Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Fork-detection guards removed from test-mention-reply-toplevel — mitigated today by job-level workflow_dispatch guard, but creates fragile state

The "Check if fork PR" step and all if: steps.fork-check.outputs.is_fork != 'true' step conditions are removed from test-mention-reply-toplevel. The job currently has a job-level if: github.event_name == 'workflow_dispatch' guard, which means fork PRs cannot trigger this job at all today — the removal has no immediate security impact.

However, the same concern applies: if the job-level guard is ever relaxed (e.g., to run on pull_request_target), there would be no step-level fallback. The Setup credentials step (which fetches AWS OIDC-derived OPENAI_API_KEY, ANTHROPIC_API_KEY, GITHUB_APP_TOKEN) would run unconditionally for fork contributors.

The workflow_dispatch guard provides sufficient protection for the current state, but the defense-in-depth layer is gone.

id: fork-check
run: |
# Use default empty string to handle edge cases (deleted branches, malformed events)
HEAD_REPO="${{ github.event.pull_request.head.repo.full_name || '' }}"
if [[ "${{ github.event_name }}" == "pull_request" && "$HEAD_REPO" != "${{ github.repository }}" && -n "$HEAD_REPO" ]]; then
echo "⏭️ Skipping - fork PR (secrets not available)"
echo "is_fork=true" >> $GITHUB_OUTPUT
else
echo "is_fork=false" >> $GITHUB_OUTPUT
fi

- name: Checkout code
if: steps.fork-check.outputs.is_fork != 'true'
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Setup pnpm
if: steps.fork-check.outputs.is_fork != 'true'
uses: pnpm/action-setup@8912a9102ac27614460f54aedde9e1e7f9aec20d # v6.0.5
with:
run_install: false

- name: Setup Node.js
if: steps.fork-check.outputs.is_fork != 'true'
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 24
cache: pnpm

- name: Build action
if: steps.fork-check.outputs.is_fork != 'true'
run: pnpm install --frozen-lockfile && pnpm build

- name: Setup credentials
if: steps.fork-check.outputs.is_fork != 'true'
uses: docker/cagent-action/setup-credentials@367a30ddb41e0156459d03750f508eac03f3c38a # v1.5.5

- name: Create anchor issue comment on current PR
if: steps.fork-check.outputs.is_fork != 'true'
id: create-anchor
env:
GH_TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
Expand All @@ -256,7 +224,6 @@ jobs:
echo "test_comment_id=$COMMENT_ID" >> $GITHUB_OUTPUT

- name: Write synthetic issue_comment event
if: steps.fork-check.outputs.is_fork != 'true'
run: |
COMMENT_ID="${{ steps.create-anchor.outputs.test_comment_id }}"
jq -n \
Expand All @@ -282,7 +249,6 @@ jobs:
}' > /tmp/test-event-toplevel.json

- name: Run mention-reply handler
if: steps.fork-check.outputs.is_fork != 'true'
id: mention-handler
env:
INPUT_GITHUB-TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
Expand All @@ -293,7 +259,6 @@ jobs:
node "$GITHUB_WORKSPACE/dist/mention-reply.js"

- name: Assert should-reply output
if: steps.fork-check.outputs.is_fork != 'true'
run: |
SHOULD_REPLY="${{ steps.mention-handler.outputs.should-reply }}"
echo "should-reply=$SHOULD_REPLY"
Expand All @@ -307,7 +272,7 @@ jobs:
fi

- name: Run mention reply
if: steps.fork-check.outputs.is_fork != 'true' && steps.mention-handler.outputs.should-reply == 'true'
if: steps.mention-handler.outputs.should-reply == 'true'
id: run-reply
uses: ./review-pr/mention-reply
with:
Expand All @@ -323,7 +288,7 @@ jobs:
skip-auth: "true"

- name: Verify reply was posted
if: steps.fork-check.outputs.is_fork != 'true' && steps.mention-handler.outputs.should-reply == 'true'
if: steps.mention-handler.outputs.should-reply == 'true'
env:
GH_TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
run: |
Expand All @@ -336,7 +301,7 @@ jobs:
echo "✅ Reply posted successfully ($FOUND comment(s) found)"

- name: Cleanup test comments
if: always() && steps.fork-check.outputs.is_fork != 'true'
if: always()
continue-on-error: true
env:
GH_TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
Expand Down Expand Up @@ -366,44 +331,27 @@ jobs:
env:
TEST_PR_NUMBER: ${{ github.event.pull_request.number || inputs.pr_number }}
steps:
- name: Check if fork PR
id: fork-check
run: |
HEAD_REPO="${{ github.event.pull_request.head.repo.full_name || '' }}"
if [[ "${{ github.event_name }}" == "pull_request" && "$HEAD_REPO" != "${{ github.repository }}" && -n "$HEAD_REPO" ]]; then
echo "⏭️ Skipping - fork PR (secrets not available)"
echo "is_fork=true" >> $GITHUB_OUTPUT
else
echo "is_fork=false" >> $GITHUB_OUTPUT
fi

- name: Checkout code
if: steps.fork-check.outputs.is_fork != 'true'
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Setup pnpm
if: steps.fork-check.outputs.is_fork != 'true'
uses: pnpm/action-setup@8912a9102ac27614460f54aedde9e1e7f9aec20d # v6.0.5
with:
run_install: false

- name: Setup Node.js
if: steps.fork-check.outputs.is_fork != 'true'
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 24
cache: pnpm

- name: Build action
if: steps.fork-check.outputs.is_fork != 'true'
run: pnpm install --frozen-lockfile && pnpm build

- name: Setup credentials
if: steps.fork-check.outputs.is_fork != 'true'
uses: docker/cagent-action/setup-credentials@367a30ddb41e0156459d03750f508eac03f3c38a # v1.5.5

- name: Create anchor review comment on current PR
if: steps.fork-check.outputs.is_fork != 'true'
id: create-anchor
env:
GH_TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
Expand All @@ -428,7 +376,6 @@ jobs:
echo "test_comment_id=$COMMENT_ID" >> $GITHUB_OUTPUT

- name: Write synthetic pull_request_review_comment event
if: steps.fork-check.outputs.is_fork != 'true'
run: |
COMMENT_ID="${{ steps.create-anchor.outputs.test_comment_id }}"
jq -n \
Expand All @@ -455,7 +402,6 @@ jobs:
}' > /tmp/test-event-inline.json

- name: Run mention-reply handler
if: steps.fork-check.outputs.is_fork != 'true'
id: mention-handler
env:
INPUT_GITHUB-TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
Expand All @@ -466,7 +412,6 @@ jobs:
node "$GITHUB_WORKSPACE/dist/mention-reply.js"

- name: Assert should-reply output
if: steps.fork-check.outputs.is_fork != 'true'
run: |
SHOULD_REPLY="${{ steps.mention-handler.outputs.should-reply }}"
echo "should-reply=$SHOULD_REPLY"
Expand All @@ -478,7 +423,7 @@ jobs:
fi

- name: Assert inline outputs
if: steps.fork-check.outputs.is_fork != 'true' && steps.mention-handler.outputs.should-reply == 'true'
if: steps.mention-handler.outputs.should-reply == 'true'
run: |
IS_INLINE="${{ steps.mention-handler.outputs.is-inline }}"
IN_REPLY_TO_ID="${{ steps.mention-handler.outputs.in-reply-to-id }}"
Expand All @@ -495,7 +440,7 @@ jobs:
echo "✅ in-reply-to-id=$IN_REPLY_TO_ID (matches anchor comment)"

- name: Run mention reply
if: steps.fork-check.outputs.is_fork != 'true' && steps.mention-handler.outputs.should-reply == 'true'
if: steps.mention-handler.outputs.should-reply == 'true'
id: run-reply
uses: ./review-pr/mention-reply
with:
Expand All @@ -511,7 +456,7 @@ jobs:
skip-auth: "true"

- name: Verify inline reply was posted in thread
if: steps.fork-check.outputs.is_fork != 'true' && steps.mention-handler.outputs.should-reply == 'true'
if: steps.mention-handler.outputs.should-reply == 'true'
env:
GH_TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
ANCHOR_ID: ${{ steps.create-anchor.outputs.test_comment_id }}
Expand All @@ -526,7 +471,7 @@ jobs:
echo "✅ Inline reply posted successfully"

- name: Cleanup anchor comment and thread replies
if: always() && steps.fork-check.outputs.is_fork != 'true'
if: always()
continue-on-error: true
env:
GH_TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
run: pnpm biome ci .

- name: Run actionlint
uses: raven-actions/actionlint@e01d1ea33dd6a5ed517d95b4c0c357560ac6f518 # v2.1.1
uses: raven-actions/actionlint@205b530c5d9fa8f44ae9ed59f341a0db994aa6f8 # v2.1.2

Check notice

Code scanning / poutine

Github Action from Unverified Creator used Note test

Usage of the following GitHub Actions repositories was detected in workflows
or composite actions, but their owner is not a verified creator.
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
fail-on-error: true
# Disable shellcheck - it reports info/style warnings as errors
Expand Down
Loading