Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cx: desktop settings reporting #21646

Merged
merged 17 commits into from
Apr 1, 2025
Merged

cx: desktop settings reporting #21646

merged 17 commits into from
Apr 1, 2025

Conversation

sarahsanders-docker
Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker commented Dec 16, 2024 •
edited
Loading

Description

  • Added guide on desktop settings reporting

NOTE: To go out with DD 4.40 release in EA

Related issues or tickets

ENGDOCS-2346

Reviews

  • Technical review
  • Editorial review
  • Product review

@sarahsanders-docker sarahsanders-docker added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Dec 16, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 16, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 354bb3c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67e59215ea24bb00085c513b
😎 Deploy Preview https://deploy-preview-21646--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarahsanders-docker sarahsanders-docker changed the title [WIP] cx: compliance reporting [WIP] cx: desktop settings reporting Dec 17, 2024
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review December 18, 2024 17:56
@sarahsanders-docker sarahsanders-docker changed the title [WIP] cx: desktop settings reporting cx: desktop settings reporting Dec 18, 2024
aevesdocker
aevesdocker requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just lil' nits

@sarahsanders-docker sarahsanders-docker deleted the compliance-reporting branch January 27, 2025 22:21
@sarahsanders-docker sarahsanders-docker restored the compliance-reporting branch January 27, 2025 22:21
sarahsanders-docker and others added 10 commits March 20, 2025 09:52
@sarahsanders-docker
Add compliance-reporting.md to generate URL
54b5782
@sarahsanders-docker
Add content
dac4fb9
@sarahsanders-docker
First proofread
761330e
@sarahsanders-docker
Add company option to choose profile page flow
753bc3c
@sarahsanders-docker @aevesdocker
Update content/manuals/security/for-admins/hardened-desktop/settings-…
bf0d560 
…management/compliance-reporting.md

Co-authored-by: Allie Sadler <[email protected]>
@sarahsanders-docker @aevesdocker
Update content/manuals/security/for-admins/hardened-desktop/settings-…
76d906c 
…management/compliance-reporting.md

Co-authored-by: Allie Sadler <[email protected]>
@sarahsanders-docker @aevesdocker
Update content/manuals/security/for-admins/hardened-desktop/settings-…
f66e036 
…management/compliance-reporting.md

Co-authored-by: Allie Sadler <[email protected]>
@sarahsanders-docker @aevesdocker
Update content/manuals/security/for-admins/hardened-desktop/settings-…
1eb3012 
…management/compliance-reporting.md

Co-authored-by: Allie Sadler <[email protected]>
@sarahsanders-docker @aevesdocker
Update content/manuals/security/for-admins/hardened-desktop/settings-…
a7e8e35 
…management/compliance-reporting.md

Co-authored-by: Allie Sadler <[email protected]>
@sarahsanders-docker @aevesdocker
Update content/manuals/security/for-admins/hardened-desktop/settings-…
7736d05 
…management/compliance-reporting.md

Co-authored-by: Allie Sadler <[email protected]>
@ajthilakan
Copy link

ajthilakan commented Mar 21, 2025 •
edited
Loading

Looks good!

@sarahsanders-docker 2 suggestions:

  • Can we elaborate on the warning i.e. while versions older than 4.40 can't report on compliance - they could still be on the latest policy and technically "compliant"
  • Can we also elaborate on the Early Access Availability callout - e,g, "You might not see this yet, as we are gradually rolling this out"

@sarahsanders-docker sarahsanders-docker added status/review and removed status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. labels Mar 25, 2025
@sarahsanders-docker sarahsanders-docker requested a review from a team March 25, 2025 16:15
aevesdocker
aevesdocker requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few more nits.

Also, is it worth adding a 'what's next' bit with a link to this new page from

https://docs.docker.com/security/for-admins/hardened-desktop/settings-management/configure-admin-console/
https://docs.docker.com/security/for-admins/hardened-desktop/settings-management/configure-json-file/
?

sarahsanders-docker and others added 3 commits March 27, 2025 11:52
@sarahsanders-docker @aevesdocker
Update content/manuals/security/for-admins/hardened-desktop/settings-…
3270d37 
…management/compliance-reporting.md

Co-authored-by: Allie Sadler <[email protected]>
@sarahsanders-docker @aevesdocker
Update content/manuals/security/for-admins/hardened-desktop/settings-…
71b8df0 
…management/compliance-reporting.md

Co-authored-by: Allie Sadler <[email protected]>
@sarahsanders-docker
feedback from Ajith
354bb3c
@sarahsanders-docker
Copy link
Collaborator Author

Looks good!

@sarahsanders-docker 2 suggestions:

  • Can we elaborate on the warning i.e. while versions older than 4.40 can't report on compliance - they could still be on the latest policy and technically "compliant"
  • Can we also elaborate on the Early Access Availability callout - e,g, "You might not see this yet, as we are gradually rolling this out"

added a new callout to clarify early access :) putting that clarification in the summary bar is tricky, but this is clarified in the section for accessing the feature. also updated the other callout!

@sarahsanders-docker sarahsanders-docker requested a review from a team March 28, 2025 15:05
@aevesdocker aevesdocker added this to the 4.40 milestone Mar 28, 2025
@craig-osterhout craig-osterhout merged commit 256da1a into docker:main Apr 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevesdocker aevesdocker aevesdocker approved these changes

@pla-sam pla-sam Awaiting requested review from pla-sam

@ajthilakan ajthilakan Awaiting requested review from ajthilakan

Assignees
No one assigned
Labels
area/security status/review
Projects
None yet
Milestone
4.40
Development

Successfully merging this pull request may close these issues.
5 participants
@sarahsanders-docker @ajthilakan @aevesdocker @pla-sam @craig-osterhout