Make systemd socket activation actually work #93
Conversation
When trying socket activation for my Docker network plugin, I noticed that the first request to the plugin never reached the plugin. As it turns out, the relevant code for extracting the passed-in socket from systemd never got called. I think this caused systemd to failover, cede the socket and try running the plugin normally, but at that point, docker already hangs. Signed-off-by: Steffen Müthing <[email protected]>
|
Can we please get this merged? This fixes the bug that causes the documented way of spawning plugins on demand (and also preventing race conditions, as far as I can tell) to fail, which is quite annoying. |
|
Sorry it's taken me a while to review this one. I had reservations about adding this back as it was removed along with a dependency on cgo. Now we have support for building without systemd at all, it's likely safe to but due to https://github.com/docker/go-plugins-helpers/blob/master/sdk/unix_listener_nosystemd.go returning |
|
For the moment, I'm building the plugin I wanted to use with a vendorized version of go-plugin-helpers which has this patch applied, so it's not super urgent, but I figure this is probably breaking other people's setups as well. |
When trying socket activation for my Docker network plugin, I noticed
that the first request to the plugin never reached the plugin. As it
turns out, the relevant code for extracting the passed-in socket from
systemd never got called. I think this caused systemd to failover,
cede the socket and try running the plugin normally, but at that
point, docker already hangs.
Signed-off-by: Steffen Müthing [email protected]