Skip to content

fix(devops): Enable HMR/Watch by correcting CMD and NODE_ENV #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix(devops): Enable HMR/Watch by correcting CMD and NODE_ENV #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ARG NODE_VERSION=19.5.0
FROM node:${NODE_VERSION}-alpine

# Use production node environment by default.
ENV NODE_ENV production
ENV NODE_ENV=production


WORKDIR /usr/src/app
Expand Down Expand Up @@ -38,4 +38,4 @@ USER node
EXPOSE 3000

# Run the application in dev mode to use with Compose watch feature
CMD npm run dev
CMD ["nodemon", "server.js"]
2 changes: 1 addition & 1 deletion compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ services:
depends_on:
- todo-database
environment:
NODE_ENV: production
NODE_ENV: development
ports:
- 3000:3000
- 35729:35729
Expand Down