Repository navigation
update-go: Keep major.minor Go versions on their series - #542
Merged
Merged
Conversation
Upstreams pin full patch versions, so the bot replaced our major.minor GO_VERSION with the upstream patch release. Now it trims the upstream version to major.minor when ours has no patch. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
crazy-max
approved these changes
Oct 19, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The focused change matches the intended behavior, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Preserves major.minor Go version pins when the update bot receives full patch versions from upstream.
Changes:
- Detects existing series-only pins and trims upstream versions accordingly.
- Keeps patch-pinned updates unchanged and logs the selected version.
| File | Description |
|---|---|
.github/workflows/update-go.yml |
Preserves Go version pin precision during Dockerfile updates. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreams pin full patch versions, so the bot replaced our major.minor GO_VERSION with the upstream patch release.
Now it trims the upstream version to major.minor when ours has no patch.