Repository navigation
pkg/containerd: deb: remove obsolete override_dh_systemd_start - #549
Merged
Merged
Conversation
Commit [containerd-packaging@ca48bd1] explicitly enabled restart-after-upgrade to address docker/for-linux#813. Commit 9a1150137dd6d98dc2f6268479065c14ea2efc12 additionally replaced try-restart with restart in the generated postinst. When package removal had already stopped the service, try-restart would leave it stopped. Debhelper 10.10.6 fixed the latter behavior upstream (Debian [879727]), and restart-after-upgrade is the default in compat 10 and later. All supported build distributions therefore provide the intended behavior without this override. The override is also already unused: dh_installsystemd replaced dh_systemd_start in the default sequence in compat 11. Remove the override as it's now redundant. [containerd-packaging@ca48bd1]: docker/containerd-packaging@ca48bd1 [containerd-packaging@9a11501]: docker/containerd-packaging@9a11501 [879727]: https://bugs.debian.org/879727 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
pkg/containerd: deb: remove obsolete override_dh_systemd_start
Commit containerd-packaging@ca48bd1 explicitly enabled restart-after-upgrade to address docker/for-linux#813.
Commit 9a1150137dd6d98dc2f6268479065c14ea2efc12 additionally replaced try-restart with restart in the generated postinst. When package removal had already stopped the service, try-restart would leave it stopped.
Debhelper 10.10.6 fixed the latter behavior upstream (Debian 879727), and restart-after-upgrade is the default in compat 10 and later. All supported build distributions therefore provide the intended behavior without this override.
The override is also already unused: dh_installsystemd replaced dh_systemd_start in the default sequence in compat 11.
Remove the override as it's now redundant.
Verified that there's no difference;