-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix: ssr TypeError: Cannot read property 'indexOf' of undefined #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See this problem in issue: docsifyjs#704
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/6x5nWFyDtaarQUUPrdaQFT1BV7u3 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6428c84:
|
@trusktr @Koooooo-7 May I ask what is the status of this PR? Since it resolves a major issue that blocks the usage of SSR, I really hope it could be merged soon. |
@xiao99xiao Cause the SSR refactor has not set in place yet, it may be late to merge. @trusktr do u think we could merge it as a patch for current SSR solution? cc @docsifyjs/reviewers |
Yeah, this is already fixed in my work. SSR is working, but not all things work yet. Namely we still need some special handling for plugins. Another issue I have is I haven't installed a VM for testing, the tests don't pass in my native OS. I will circle back again soon, i haven't forgotten! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
see #2105 |
See this problem in issue:
#704
Summary
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
Tested in the following browsers: