Use development file #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that recent versions of PHPUnit have started honoring display_errors. This prompted me to do this more global change, which means we no longer mean to turn assertions on manually, since that is done in the development INI file.
greg0ire
added a commit
to greg0ire/DoctrineBundle
that referenced
this pull request
Oct 10, 2025
This is similar to doctrine/.github#67
greg0ire
requested review from
GromNaN,
SenseException,
alcaeus,
beberlei,
derrabus,
malarzm,
morozov,
ostrolucky,
paulinevos and
stof
Member
Author
|
Will tag this as a major since it could have unforeseen consequences. |
morozov
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that recent versions of PHPUnit have started honoring display_errors. This prompted me to do this more global change, which means we no longer mean to turn assertions on manually, since that is done in the development INI file.
Proof that it still works: doctrine/collections#475
Proof that the underlying change should address the issue: doctrine/DoctrineBundle#2069 (comment)