Phpunit 11 #2040
Merged
Phpunit 11 #2040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
requested review from
derrabus,
stof,
ostrolucky,
SenseException and
dmaicher
derrabus
reviewed
Sep 12, 2025
| $commandTester->getDisplay(), | ||
| ); | ||
|
|
||
| restore_exception_handler(); |
There was a problem hiding this comment.
Is this still necessary? I thought we've fixed that. 😕
There was a problem hiding this comment.
It's sufficient to avoid the message in the commit message. If you have a better way, I'm interested.
There was a problem hiding this comment.
Let's go with this instead symfony/symfony#53812 (comment)
There was a problem hiding this comment.
IIRC, the http-kernel component changes its behavior based on the availability of symfony/runtime (as it knows symfony/runtime manages the error handler already anyway for non-test usage).
There was a problem hiding this comment.
@ostrolucky last time I tried that, it didn't work, but now it does. I must have messed up somehow.
PHPUnit 11 is not a fan of that: 1) Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection\Compiler\CacheCompatibilityPassTest::testCacheConfigUsingServiceDefinedByApplication Error: Typed property MockObject_Region_05946efc::$__phpunit_state must not be accessed before initialization /home/greg/dev/DoctrineBundle/vendor/doctrine/orm/src/Cache/DefaultCacheFactory.php:58 /tmp/sf_kernel_ba1be5d8f77bfc90137d39c20fb6e3be/var/cache/test/Container7B0Xppy/getDoctrine_Orm_DefaultConfigurationService.php:37 /tmp/sf_kernel_ba1be5d8f77bfc90137d39c20fb6e3be/var/cache/test/Container7B0Xppy/Doctrine_Bundle_DoctrineBundle_Tests_DependencyInjection_Fixtures_TestKernel_zxZtpVTestContainer.php:93 /tmp/sf_kernel_ba1be5d8f77bfc90137d39c20fb6e3be/var/cache/test/Container7B0Xppy/getDoctrine_Orm_DefaultEntityManagerService.php:25 /tmp/sf_kernel_ba1be5d8f77bfc90137d39c20fb6e3be/var/cache/test/Container7B0Xppy/getDoctrine_Orm_DefaultEntityManagerService.php:22 /home/greg/dev/DoctrineBundle/vendor/doctrine/orm/src/EntityManager.php:162 /home/greg/dev/DoctrineBundle/src/CacheWarmer/DoctrineMetadataCacheWarmer.php:37 /home/greg/dev/DoctrineBundle/vendor/symfony/framework-bundle/CacheWarmer/AbstractPhpFileCacheWarmer.php:41 /home/greg/dev/DoctrineBundle/vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php:96 /home/greg/dev/DoctrineBundle/vendor/symfony/http-kernel/Kernel.php:520 /home/greg/dev/DoctrineBundle/vendor/symfony/http-kernel/Kernel.php:718 /home/greg/dev/DoctrineBundle/vendor/symfony/http-kernel/Kernel.php:120 /home/greg/dev/DoctrineBundle/tests/DependencyInjection/Compiler/CacheCompatibilityPassTest.php:80 Anyway, do not mock what you do not own ™️
greg0ire
force-pushed
the
phpunit-11
branch
from
d708b77 to
79c12b6
Compare
PHPUnit 11 warns about tests that involvke Symfony kernels: > Test code or tested code did not remove its own exception handlers See symfony/symfony#53812
greg0ire
force-pushed
the
phpunit-11
branch
from
79c12b6 to
c78a03b
Compare
ostrolucky
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.