Merge 2.16.x up into 2.17.x #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this should have been part of 2dc0114.
The legacyCacheConfigurationProvider was used to test cases that are using metadata_cache_driver, but that key was undeprecated in fdc5a49.
Remove illegitimate mentions of "legacy"
That should have been done in fa3e8e3.
According to #1300 (comment), this should be OK (meaning Symfony users should see the deprecations). I'm doing this for 2 reasons: - Having a link to the deprecation is great. - consistency.
It is useless since 84d23e5, when the counterpart phpcs:disable was removed.
The linked pull request has been merged a long time ago.
Remove useless comment
Switch entirely to doctrine/deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.