Skip to content

Conversation

@ajgarlag
Copy link

This reverts commit 81cc5b3 of #2069.

As long as Symfony 8 is not final yet, we should not indicate compatibility. This should be added to the 3.1.0 milestone, so we don't forget to merge it before we release a stable 3.1.0.

This reverts commit 81cc5b3.
@ostrolucky
Copy link
Member

Hmm I believe it's too late now. Even if we merge and release this, composer will just pick up older version of the bundle when installing it with Symfony 8. Intention was to do this revert before a release, but it was forgotten. Not sure if we can do something about it now.

@nicolas-grekas
Copy link
Member

There's nothing wrong advertising Symfony 8 as supported. The release is close, in feature freeze: the scope is known.

@stof
Copy link
Member

stof commented Oct 15, 2025

Even if we merge and release this, composer will just pick up older version of the bundle when installing it with Symfony 8. Intention was to do this revert before a release, but it was forgotten.

the merge commit of the previous PR is not part of any tag. It was merged after the last release.

@ostrolucky
Copy link
Member

Ah ok somehow I though it was merged into 3.x. We are all good then, we should ideally merge this pr before release 3.1 though

@greg0ire greg0ire added this to the 3.1.0 milestone Oct 15, 2025
@VincentLanglet
Copy link
Contributor

VincentLanglet commented Nov 9, 2025

Ah ok somehow I though it was merged into 3.x. We are all good then, we should ideally merge this pr before release 3.1 though

Why ? Symfony already has multiple beta version and won't have any BC break.
If Symfony 8 works fine with this bundle as if, it's better to allow people installing beta version if they want to.

A 3.1.0 release would be even better, like it was done for the migration bundle
https://github.com/doctrine/DoctrineMigrationsBundle/releases/tag/3.6.0

@ostrolucky
Copy link
Member

ostrolucky commented Nov 9, 2025

Why ? Symfony already has multiple beta version and won't have any BC break.

I don't share your optimism. I remember some BC breaks in Symfony happened even in RC versions. That said, I wrote my comment when beta version didn't exist yet. We can consider keeping the support for Symfony 8 in next doctrine-bundle release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants