Skip to content

Use LazyGhostObject for proxy objects #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Use LazyGhostObject for proxy objects #877

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d1cacd
Use LazyGhostObject for proxy objects
GromNaN Jan 22, 2025
cd20e33
No update required. Activate lazy ghost objects only when possible.
GromNaN Jan 23, 2025
adba204
Add use_lazy_ghost_object configuration
GromNaN Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"php": "^8.1",
"ext-mongodb": "^1.16",
"composer-runtime-api": "^2.0",
"doctrine/mongodb-odm": "^2.6",
"doctrine/mongodb-odm": "^2.10@dev",
"doctrine/persistence": "^3.0",
"psr/log": "^1.0 || ^2.0 || ^3.0",
"symfony/config": "^6.4 || ^7.0",
Expand Down
4 changes: 2 additions & 2 deletions config/mongodb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Doctrine\Bundle\MongoDBBundle\Repository\ContainerRepositoryFactory;
use Doctrine\ODM\MongoDB\DocumentManager;
use Doctrine\ODM\MongoDB\Tools\ResolveTargetDocumentListener;
use ProxyManager\Proxy\GhostObjectInterface;
use Doctrine\Persistence\Proxy;
use Symfony\Bridge\Doctrine\ContainerAwareEventManager;
use Symfony\Bridge\Doctrine\Security\User\EntityUserProvider;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
Expand Down Expand Up @@ -54,7 +54,7 @@
'%doctrine_mongodb.odm.document_managers%',
'%doctrine_mongodb.odm.default_connection%',
'%doctrine_mongodb.odm.default_document_manager%',
GhostObjectInterface::class,
Proxy::class,
service('service_container'),
])

Expand Down
7 changes: 2 additions & 5 deletions src/DependencyInjection/DoctrineMongoDBExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?php

Check failure on line 1 in src/DependencyInjection/DoctrineMongoDBExtension.php

View workflow job for this annotation

GitHub Actions / static-analysis / PHPStan (PHP: 8.4) 

Ignored error pattern #^Call to function method_exists\(\) with 'Doctrine\\\\ODM\\\\MongoDB\\\\Configuration' and 'setUseTransactional…' will always evaluate to true\.$# (function.alreadyNarrowedType) in path /home/runner/work/DoctrineMongoDBBundle/DoctrineMongoDBBundle/src/DependencyInjection/DoctrineMongoDBExtension.php was not matched in reported errors.

declare(strict_types=1);

Expand Down Expand Up @@ -46,7 +46,6 @@
use function in_array;
use function interface_exists;
use function is_dir;
use function method_exists;
use function sprintf;

/**
Expand Down Expand Up @@ -255,12 +254,10 @@
'setPersistentCollectionDir' => '%doctrine_mongodb.odm.persistent_collection_dir%',
'setPersistentCollectionNamespace' => '%doctrine_mongodb.odm.persistent_collection_namespace%',
'setAutoGeneratePersistentCollectionClasses' => '%doctrine_mongodb.odm.auto_generate_persistent_collection_classes%',
'setUseLazyGhostObject' => true,
'setUseTransactionalFlush' => $documentManager['use_transactional_flush'],
];

if (method_exists(ODMConfiguration::class, 'setUseTransactionalFlush')) {
$methods['setUseTransactionalFlush'] = $documentManager['use_transactional_flush'];
}

if ($documentManager['repository_factory']) {
$methods['setRepositoryFactory'] = new Reference($documentManager['repository_factory']);
}
Expand Down
Loading