This repository was archived by the owner on Feb 5, 2024. It is now read-only.
Added urlencode to filename for attachments#130
Closed
Tischi86 wants to merge 2 commits intodoctrine:masterfrom
Closed
Added urlencode to filename for attachments#130Tischi86 wants to merge 2 commits intodoctrine:masterfrom
Tischi86 wants to merge 2 commits intodoctrine:masterfrom
Conversation
Encoding the filename makes it possible to get attachments with spaces.
beberlei
reviewed
Apr 12, 2017
| foreach ($data AS $filename => $attachment) { | ||
| if (isset($attachment['stub']) && $attachment['stub']) { | ||
| $instance = Attachment::createStub($attachment['content_type'], $attachment['length'], $attachment['revpos'], $client, $basePath . $filename); | ||
| $instance = Attachment::createStub($attachment['content_type'], $attachment['length'], $attachment['revpos'], $client, $basePath . urlencode($filename)); |
Member
There was a problem hiding this comment.
I am pretty sure this is something that the Attachment class should fix, not the calling code. Or?
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding the filename makes it possible to get attachments with spaces.