-
-
Notifications
You must be signed in to change notification settings - Fork 71
Introduce ClassLocator
to find class names for attribute drivers
#433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a6b38ce
Optimize: use O(1) item lookup instead of O(M)
rela589n 8b501b9
Refactor: extract `FilePathNameIterator`
rela589n df06aca
Refactor: extract `DirectoryFilesIterator`
rela589n a241c82
Feature: accept `iterable` of file paths
rela589n dbed9f5
Introduce ClassLocator to find classes names for attribute drivers
GromNaN 539d8ea
Refactor getAllClassNames with early throw
GromNaN 32063d9
Fix array-key in class name list
GromNaN b2a26ec
Make FileClassLocator accept an iterable of SplFileInfo
GromNaN 2b0e795
Import class from Foo.mphp file
GromNaN 76acfc0
ternary.shortNotAllowed identifier added in v1.6
GromNaN f75ac79
Fix comment
GromNaN 49858ad
Update comment for ternary.shortNotAllowed and realpath
GromNaN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Doctrine\Persistence\Mapping\Driver; | ||
|
||
/** | ||
* ClassLocator is an interface for classes that can provide a list of class names. | ||
*/ | ||
interface ClassLocator | ||
{ | ||
/** @return list<class-string> */ | ||
public function getClassNames(): array; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Doctrine\Persistence\Mapping\Driver; | ||
|
||
/** | ||
* Basic implementation of ClassLocator that passes a list of class names. | ||
*/ | ||
final class ClassNames implements ClassLocator | ||
{ | ||
/** @param list<class-string> $classNames */ | ||
public function __construct( | ||
private array $classNames, | ||
) { | ||
} | ||
|
||
/** @return list<class-string> */ | ||
public function getClassNames(): array | ||
{ | ||
return $this->classNames; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.