Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create website schema validation workflow #873

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

SenseException
Copy link
Member

No description provided.

@SenseException
Copy link
Member Author

Next to some failing static analysis workflows, the newly added website-config vlidation fails because 2.x isn't a coherent branch format compared to the other repositories. Should the branch name be changed or should the validation itself allow formats like 2.x?

@dbu
Copy link
Member

dbu commented Mar 21, 2025

what branch naming do the other repositories do, is there a branch naming policy documented somewhere? we can change to that, i don't mind.

@SenseException
Copy link
Member Author

I don't think we have a fix branch naming policy. Other repositories have branch names like 2.0.x, 2.1.x, and so on. At least the ones that have a documentation. If we can agree on this format, I can provide a documentation about the branch names.

@dbu
Copy link
Member

dbu commented Mar 23, 2025

i renamed 2.x to 2.0.x and 1.x to 1.5.x

i hope i won't forget to create 2.1.x before merging new features 😅

@dbu
Copy link
Member

dbu commented Mar 23, 2025

and fixing the CS issues in #874

@dbu
Copy link
Member

dbu commented Mar 23, 2025

can you pleaes rebase this branch? i expect it to become all green :-D

@greg0ire greg0ire closed this Mar 23, 2025
@greg0ire greg0ire reopened this Mar 23, 2025
@greg0ire
Copy link
Member

@dbu rebasing is not necessary, closing and reopening is enough. The build failure shows that we should update .doctrine-project.json with the new names.

Branches have been renamed to be consistent with other Doctrine
repositories.
@greg0ire greg0ire requested a review from dbu March 23, 2025 12:37
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks for the cleaning up

@dbu dbu merged commit 7fc9de4 into doctrine:2.0.x Mar 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants