Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DragonFlyBSD 6.4-RELEASE support #182

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

movepointsolutions
Copy link

it has endianness-related functions named the same

it has endianness-related functions named the same
@movepointsolutions
Copy link
Author

I can't verify if previous versions of DFLY were ok with the FreeBSD code branch
So it could probably break support for older dragonflies

@movepointsolutions
Copy link
Author

Please don't merge this commit, I'll come back with exact dfly version check

@movepointsolutions
Copy link
Author

Whatever, I'm not that proficient in git

Please don't merge this commit, I'll come back with exact dfly version check

@movepointsolutions
Copy link
Author

To be precise,
/usr/include/sys/param.h:#define __DragonFly_version 600400 /* propagated to newvers */

@xanimo
Copy link
Member

xanimo commented Jan 19, 2024

going to explore this after we release 0.1.3. thanks!

@xanimo xanimo changed the base branch from 0.1.3-dev to 0.1.4-dev February 9, 2024 19:38
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally have a working environment to test this but I see what you mean:

dogecoinfoundation/0.1.4-dev:
image

your branch:
image

ACK

@xanimo
Copy link
Member

xanimo commented Mar 23, 2024

Including a demo just in case anyone else wants to test DragonFly BSD on linux. I would skip ahead from 6.4 to their daily snapshots as noted in the comment underneath the main gist. Also I would manually download and install libunistring and libevent and copy files from /usr/local/include to libdogecoin/include/ as we can't use make -C depends due to incompatible line breaks.

@movepointsolutions
Copy link
Author

Very glad to see that you support D-flies)

@michilumin michilumin self-requested a review August 27, 2024 20:33
Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-to me- looks like passive/non issue causing additions so I'm OK with it.

@michilumin
Copy link
Contributor

Whatever, I'm not that proficient in git

Please don't merge this commit, I'll come back with exact dfly version check

that's ok. nobody is.

@michilumin michilumin merged commit f944b44 into dogecoinfoundation:0.1.4-dev Aug 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants