Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: added prompt to dogecoin_wallet_load #185

Merged

Conversation

edtubbs
Copy link
Collaborator

@edtubbs edtubbs commented Jan 12, 2024

Added prompts for wallet and header database files and moved fcntl to dogecoin_spv_client_discover_peers for delayed non-blocking stdin.

@edtubbs edtubbs force-pushed the 0.1.3-dev-overwrite-prompt branch 13 times, most recently from c63e69f to 91be899 Compare January 19, 2024 23:01
headersdb: added prompt to headerdb load
headersdb_file: added prompt to dogecoin_headers_db_load
headersdb_file: removed check from dogecoin_headers_db_free
seal: moved memory allocations for TEST_PASSWD
spv: added prompt to client load
spv: moved fcntl to dogecoin_spv_client_discover_peers
spvnode: added prompt to client load calls
spvnode: added handle_sigint to reset stdin to blocking
spvnode: added dogecoin_spv_client_free and dogecoin_ecc_stop on failure
wallet: added prompt to dogecoin_wallet_init
wallet: added prompt to dogecoin_wallet_load
wallet: added no prompt to wallet API load calls
wallet: added encryption of random seed with software
wallet: added dogecoin_wallet_free to dogecoin_wallet_init on failures
such: added seed_to_master_key command
doc: added seed_to_master_key to tools.md
doc: added no_prompt to tools.md
test: added no prompt to spv_tests
test: added no prompt to wallet_tests
@edtubbs edtubbs force-pushed the 0.1.3-dev-overwrite-prompt branch from 91be899 to 5db1a5e Compare January 20, 2024 03:52
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. tested on #188 all memory has been freed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seed to master key function == very good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ❤️ 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdin non blocking to accept commands during display for win32, v. good thanks for remembering

Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good and down the right path to user friendliness and all that jazz.

@michilumin michilumin merged commit 3ec0148 into dogecoinfoundation:0.1.3-dev Jan 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants