Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chainparams: update chain_from_b58_prefix to detect testnet and regtest #187

Merged
merged 1 commit into from
Jan 23, 2024
Merged

chainparams: update chain_from_b58_prefix to detect testnet and regtest #187

merged 1 commit into from
Jan 23, 2024

Conversation

xanimo
Copy link
Member

@xanimo xanimo commented Jan 19, 2024

No description provided.

@michilumin michilumin self-assigned this Jan 19, 2024
edtubbs
edtubbs approved these changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@edtubbs edtubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, reviewed and tested updates with #188 on x86_64 with linux.

@edtubbs edtubbs mentioned this pull request Jan 20, 2024
Merged
michilumin
michilumin approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two added cases, and resulting in just returns, should work fine by review.

@michilumin michilumin merged commit 78c63fc into dogecoinfoundation:0.1.3-dev Jan 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edtubbs edtubbs edtubbs approved these changes

@michilumin michilumin michilumin approved these changes

Assignees

@michilumin michilumin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xanimo @michilumin @edtubbs