Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip39: added fclose to error conditions #193

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

edtubbs
Copy link
Collaborator

@edtubbs edtubbs commented Jan 30, 2024

Added fclose(fp) to error conditions in src/bip39.c and src/seal.c.

seal: added fclose to error conditions
@edtubbs edtubbs force-pushed the 0.1.3-dev-fclose-fp branch from 26dde84 to 8cd3b92 Compare January 31, 2024 01:53
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, tested on x86_64-linux on jammy in wsl.

@michilumin michilumin assigned michilumin and unassigned michilumin Feb 7, 2024
@michilumin michilumin self-requested a review February 7, 2024 22:16
Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing files after done with them is quite optimal 👍

@xanimo xanimo merged commit 1d856f7 into dogecoinfoundation:0.1.3-dev Feb 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants