Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: added build type for msvc #198

Merged

Conversation

edtubbs
Copy link
Collaborator

@edtubbs edtubbs commented Feb 6, 2024

Added --config ${CMAKE_BUILD_TYPE} to the cmake --build command to specify the build type for msvc.

@edtubbs edtubbs force-pushed the 0.1.3-dev-msvc-build branch from ef8ebaa to c1442ed Compare February 7, 2024 03:45
@edtubbs
Copy link
Collaborator Author

edtubbs commented Feb 7, 2024

Updates were made to support Release mode builds, including the use of assert and disabling the USE_TPM2 flag.

Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I THINK i followed all your logic transitions here... and they were correct. I'm pretty sure.

eckey: changed assert dogecoin_base58_encode_check to check
key: changed assert dogecoin_base58_encode_check to check
tool: changed assert dogecoin_base58_encode_check to check
tool: changed assert dogecoin_pubkey_get_hex to check
seal: changed NCryptDecrypt cbOutput parameter to sizeof hdnode
seal: updated TBS_CONTEXT_PARAMS2 params to set includeTpm20
@edtubbs edtubbs force-pushed the 0.1.3-dev-msvc-build branch from c1442ed to 2a23da2 Compare February 7, 2024 17:09
@edtubbs
Copy link
Collaborator Author

edtubbs commented Feb 7, 2024

TPM2 tests now successfully pass in Release mode.

Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. tested and built in .git repo and gitian .zip.

Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on tpm fixes

@michilumin michilumin merged commit 4844534 into dogecoinfoundation:0.1.3-dev Feb 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants