added 'tbs' library link #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes build due error due to unresolved external symbols 'Tbsi_Context_Create, Tbsip_Context_Close, and Tbsip_Submit_Command' in dogecoin_generate_mnemonic_encrypt_with_tpm() Signed-off-by: nowon <[email protected]>
edtubbs
approved these changes
Feb 23, 2024
xanimo
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
ACK. Tested on 64-bit windows and ubuntu jammy wsl. On 64-bit windows, running
cmake .. -DBUILD_SHARED_LIBS=ON -DWITH_NET=ON -DUSE_TPM2=ON
cmake --build .
resolves unresolved external symbol found in seal.obj:
seal.obj : error LNK2019: unresolved external symbol Tbsi_Context_Create referenced in function dogecoin_generate_mnemonic_encrypt_with_tpm [C:\Users\dakod\source\repos\libdogecoin\build\dogecoin.vcxproj]
seal.obj : error LNK2019: unresolved external symbol Tbsip_Context_Close referenced in function dogecoin_generate_mnemonic_encrypt_with_tpm [C:\Users\dakod\source\repos\libdogecoin\build\dogecoin.vcxproj]
seal.obj : error LNK2019: unresolved external symbol Tbsip_Submit_Command referenced in function dogecoin_generate_mnemonic_encrypt_with_tpm [C:\Users\dakod\source\repos\libdogecoin\build\dogecoin.vcxproj]
C:\Users\dakod\source\repos\libdogecoin\build\Debug\dogecoin.dll : fatal error LNK1120: 3 unresolved externals [C:\Users\dakod\source\repos\libdogecoin\build\dogecoin.vcxproj]
so yeah good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when building for shared libs for win32, net, and tpm2
unresolved external symbols 'Tbsi_Context_Create, Tbsip_Context_Close, and Tbsip_Submit_Command' in dogecoin_generate_mnemonic_encrypt_with_tpm().