Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tindex and uacomment to CORE #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

qlpqlp
Copy link

@qlpqlp qlpqlp commented Dec 22, 2024

No description provided.

@qlpqlp qlpqlp added the enhancement New feature or request label Dec 22, 2024
@qlpqlp qlpqlp requested review from raffecat and edtubbs December 22, 2024 11:30
@qlpqlp qlpqlp self-assigned this Dec 22, 2024
@SomeoneWeird
Copy link
Member

I think we should really think through whether we want to add the UA comment or not. Assuming it’s transmitted (what else would it be used for?) It would let people on the network potentially block Dogeboxs from participating, even though they are stock Core.

Maybe we add an opt-in for this?

@SomeoneWeird SomeoneWeird self-requested a review December 22, 2024 11:38
@qlpqlp
Copy link
Author

qlpqlp commented Dec 22, 2024

I think we should really think through whether we want to add the UA comment or not. Assuming it’s transmitted (what else would it be used for?) It would let people on the network potentially block Dogeboxs from participating, even though they are stock Core.

Maybe we add an opt-in for this?

How can be blocked using uacomment? it can only be blocked if there is a new fork or a new protocol to allow uncomment block/filter

My approach is to add it now because rpc and zmq, wallet etc. is also not opt-in, and in the near future add an option to enable/disable each option and/change the uacomment and/or other CORE parameters, IMO

@SomeoneWeird
Copy link
Member

My approach is to add it now because rpc and zmq, wallet etc. is also not opt-in,

While this is true, they all sit behind the dogebox firewall and can't be hit. Modifying the UA will automatically expose and leak information that the instance of core is running on a dogebox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants