Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prometheus printer #534

Closed
wants to merge 2 commits into from

Conversation

atzawada
Copy link

Adding a new "printer" (reporter, exporter?) to push Kubent output to Prometheus via Pushgateway. Any feedback is appreciated.

Relates to #302 and the discussion in #218

New Configuration

Flags

  • -o prometheus is now an allowed option

Environment Variables

  • PUSHGATEWAY_URL: The URL of the Prometheus Pushgateway.
  • PUSHGATEWAY_JOB: The job to collect metrics under.

If -o prometheus is set, then both of these variables are required to be set.

Remaining Questions

  • Maybe need to expand on the configuration abilities for printers...Is environment variables the right approach or should printers be able to accept custom config/define their own flags?

Remaining Work

  • Add Pushgateway auth options
  • Add unit testing

@atzawada atzawada changed the title Add prometheus printer feat: Add prometheus printer Sep 26, 2023
@atzawada atzawada force-pushed the atzawada-add-prom-reporter branch from dae936d to 4e9fdbe Compare September 26, 2023 19:48
@isugimpy
Copy link

isugimpy commented Oct 9, 2023

Not to tell you that you shouldn't do this, but you might consider https://github.com/isugimpy/kubent_exporter/ as an alternative to this. Having a publisher built in would be pretty cool though.

Copy link

github-actions bot commented Dec 9, 2023

This PR has not seen any activity in last 60 days and has been marked as stale

@github-actions github-actions bot added the stale label Dec 9, 2023
@dark0dave dark0dave self-assigned this Dec 20, 2023
@github-actions github-actions bot removed the stale label Dec 21, 2023
@dark0dave
Copy link
Collaborator

dark0dave commented Dec 22, 2023

Hi @atzawada , I think we can support this. Not sure about adding all those env variables, we handle those in config.go. Happy to add the printer, but pushing the messages should probably be handled by another tool.

If you rebase this and add some tests I'll happily merge it.

Copy link

This PR has not seen any activity in last 60 days and has been marked as stale

@github-actions github-actions bot added the stale label Feb 21, 2024
Copy link

This PR was closed because it has been stalled for 90 days with no activity.

@github-actions github-actions bot closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants