feat: mask sensitive values via struct tags and inputs#220
Merged
josegonzalez merged 2 commits intomainfrom Apr 27, 2026
Merged
feat: mask sensitive values via struct tags and inputs#220josegonzalez merged 2 commits intomainfrom
josegonzalez merged 2 commits intomainfrom
Conversation
Adds explicit, struct-tag-driven masking of sensitive values in every user-facing logging path: the `apply --verbose` command echo, the `DOKKU_TRACE=1` log, plan mutations, and any error message that surfaces a resolved Dokku command. Inputs gain a `sensitive: true` flag and task struct fields gain a `sensitive:"true"` tag; matching values are replaced with `***` before output. `dokku_config.config` map values are always masked via a `SensitiveOverride` interface because the secret lives in the value, not the key. The `config:set --encoded` base64 form is masked alongside the raw value so the encoded argv form does not leak the secret either. Closes #203.
josegonzalez
deleted the
203-add-sensitive-value-masking-via-struct-tags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit, struct-tag-driven masking of sensitive values in every user-facing logging path: the
apply --verbosecommand echo, theDOKKU_TRACE=1log, plan mutations, and any error message that surfaces a resolved Dokku command. Inputs gain asensitive: trueflag and task struct fields gain asensitive:"true"tag; matching values are replaced with***before output.dokku_config.configmap values are always masked via aSensitiveOverrideinterface because the secret lives in the value, not the key. Theconfig:set --encodedbase64 form is masked alongside the raw value so the encoded argv form does not leak the secret either.Closes #203.