Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompile a handful of functions in mplib.c #1483

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Conversation

eperdew
Copy link
Contributor

@eperdew eperdew commented Oct 20, 2024

This is my first PR, sorry if I'm making obvious mistakes. Happy to engage on discord if that's easier.

100% matches on...

- mpLib_800588D0
- mpLib_80058970
- mpLib_800589D0
- mpLib_80058AA0
- mpLib_8005A2DC

Also got .sdata matching.

@eperdew eperdew marked this pull request as ready for review October 20, 2024 03:15
@ribbanya
Copy link
Collaborator

This is great, thank you. No need to talk on Discord if you prefer GitHub.

@ribbanya ribbanya merged commit a6a0819 into doldecomp:master Oct 20, 2024
8 checks passed
@eperdew eperdew deleted the mplib branch October 20, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants