Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeneralPane: Add BalloonTips #12829

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

GeneralPane: Add BalloonTips #12829

wants to merge 10 commits into from
+133 −57

Conversation

Dentomologist
Copy link
Contributor

I aimed to make the tooltips accurate and detailed, but encourage double-checking.

mbc07
mbc07 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@mbc07 mbc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good to me, apart from the minor nitpick I left earlier. Gave it a try and didn't notice anything wrong design-wise, all tooltips showed as expected...

JosJuice
JosJuice reviewed Jun 9, 2024
View reviewed changes
Source/Core/DolphinQt/Settings/GeneralPane.cpp Show resolved Hide resolved
Source/Core/DolphinQt/Settings/GeneralPane.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Settings/GeneralPane.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Settings/GeneralPane.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Settings/GeneralPane.cpp Outdated Show resolved Hide resolved
@Dentomologist
Copy link
Contributor Author

I've added the suggestions above.

@AdmiralCurtiss
Copy link
Contributor

@MayImilae Do you want to review those description strings?

@MayImilae
Copy link
Contributor

MayImilae commented Jun 15, 2024 •
edited
Loading

I need too, I've just been busy. I'll leave this tab open and get to it tomorrow.

EDIT: ...oh yea I have notes. I'm busy with the you know what but I'll write up a bunch of notes in the coming couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou left review comments

@JosJuice JosJuice JosJuice left review comments

@mbc07 mbc07 mbc07 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
6 participants
@Dentomologist @AdmiralCurtiss @MayImilae @Calinou @JosJuice @mbc07