Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy configuration support #13287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove legacy configuration support #13287

wants to merge 1 commit into from

Conversation

JoshuaVandaele
Copy link
Contributor

LoadLegacyConfig was written five years ago, I believe we're confident enough that most configurations have been migrated by now.

@JoshuaVandaele
Remove legacy configuration support
63d7250 
LoadLegacyConfig was written five years ago, I believe we're confident enough that most configurations have been migrated by now.
dreamsyntax
dreamsyntax approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@dreamsyntax dreamsyntax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confident enough that most configurations have been migrated

I disagree, especially with all the pre configured dolphin builds, but I also don't think it's unreasonable to drop this. Config migrations have had problems anyway, so I say go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamsyntax dreamsyntax dreamsyntax approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaVandaele @dreamsyntax