LibusbDevice: Don't detach kernel drivers on macOS #13318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjay900
force-pushed
the
dont-detach-macos
branch
from
4705a97 to
d9fc12b
Compare
sanjay900
force-pushed
the
dont-detach-macos
branch
from
d9fc12b to
10e0448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on updating GCAdapterDriver so it works for more devices, and noted that we would need to skip detaching the kernel driver in LibusbDevice too, much like we already do for GCAdapter.
secretkeysio/GCAdapterDriver#27
I have already added all the PS3 and Wii controllers i can think of, and there is a test build of GCAdapterDriver on that pull request that has these devices included.