DolphinQt/Mapping: Add setting to enable waiting for alternate mappings. #13320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using the OR-operator.
dreamsyntax
approved these changes
Feb 2, 2025
The delay is only introduced when the setting is enabled. And the setting needs to be enabled every time the dialog is opened when it's wanted, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was removed in #9685 because the delay it introduces during button mappings is annoying.
The default behavior is unchanged.
By enabling this new setting, auto generation of
|mappings using sequential button presses is again possible.Pressing X followed by Z with the setting enabled:
Screencast_20250201_001656.webm
Users occasionally ask how to map two buttons without having to press them at the same time.
Telling them to enable this setting is easier than explaining how to use the advanced mapping window.
I also did some other minor code cleanups.