fix: panic on null metrics port (#8680)

dolthub · Dec 14, 2024 · 5483f71 · 5483f71
1 parent e409d61
commit 5483f71
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/go/libraries/doltcore/servercfg/yaml_config.go b/go/libraries/doltcore/servercfg/yaml_config.go
@@ -412,6 +412,9 @@ func (cfg YAMLConfig) MetricsPort() int {
 	if cfg.MetricsConfig.Host == nil {
 		return DefaultMetricsPort
 	}
+	if cfg.MetricsConfig.Port == nil {
+		return DefaultMetricsPort
+	}
 
 	return *cfg.MetricsConfig.Port
 }

diff --git a/go/libraries/doltcore/servercfg/yaml_config_test.go b/go/libraries/doltcore/servercfg/yaml_config_test.go
@@ -414,3 +414,16 @@ listener:
 	err = ValidateConfig(cfg)
 	assert.Error(t, err)
 }
+
+func TestYAMLConfigMetrics(t *testing.T) {
+	var cfg YAMLConfig
+	err := yaml.Unmarshal([]byte(`
+metrics:
+  host: localhost
+  port: null
+`), &cfg)
+	require.NoError(t, err)
+
+	assert.Equal(t, "localhost", cfg.MetricsHost())
+	assert.Equal(t, -1, cfg.MetricsPort())
+}