Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqle] Fix diff table merge join bugs #8699

Merged
merged 3 commits into from
Dec 26, 2024
Merged

[sqle] Fix diff table merge join bugs #8699

merged 3 commits into from
Dec 26, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Dec 26, 2024 •
edited
Loading

Inappropriately using kv merge join, in several ways. No diff table support both for kvexec and diff table indexes aren't sorted, so default merge also fails. Test suite was also being skipped.

GMS side here: dolthub/go-mysql-server#2803

fixes: #8700

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
621764b ok 5937457
version total_tests
621764b 5937457
correctness_percentage
100.0

@timsehn timsehn mentioned this pull request Dec 26, 2024
Closed
jycor
jycor approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
aa41982 ok 5937457
version total_tests
aa41982 5937457
correctness_percentage
100.0

@max-hoffman max-hoffman merged commit 68651da into main Dec 26, 2024
21 checks passed
@max-hoffman max-hoffman deleted the max/diff-table-bugs branch December 26, 2024 20:16
@BrewTestBot BrewTestBot mentioned this pull request Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in join against diff table
3 participants
@max-hoffman @coffeegoddd @jycor