fix type and precision for unix_timestamp
#2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional work is required for integration with Dolt. |
3 similar comments
|
Additional work is required for integration with Dolt. |
|
Additional work is required for integration with Dolt. |
|
Additional work is required for integration with Dolt. |
max-hoffman
approved these changes
Jun 29, 2024
| @@ -456,7 +543,10 @@ func (ut *UnixTimestamp) IsNullable() bool { | |||
| } | |||
|
|
|||
| func (ut *UnixTimestamp) Type() sql.Type { | |||
| return types.Float64 | |||
| if ut.typ == nil { | |||
There was a problem hiding this comment.
can type be nil? with the constructor changes?
There was a problem hiding this comment.
The changes do add either Int64 or Float64, but I don't think it's impossible for type to the nil.
The check will prevent panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds off of: #2573