Skip to content

Conversation

mmertgunduz
Copy link

Fix #131

Hi @domferr,

I hope you're doing well!

Following our previous discussion about customizable gaps, I've implemented the feature that allows separate configuration for each inner and outer gap (left/right/top/bottom). I've tested the code and everything is working fine.

The changes introduce individual controls for:

  • Inner gaps (left, right, top, bottom)
  • Outer gaps (left, right, top, bottom)

I'd appreciate your review when you have time. Let me know if you'd like me to explain any part of the implementation in more detail.

Thanks! 🚀


Requested by me in issue #131 on Aug 23, 2024.

@domferr
Copy link
Owner

domferr commented Mar 22, 2025

Thank you so much for this contribution! Work like this is so much appreciated 🌟

I do see many edge cases that will break, mostly because during development I had to make the assumption that the inner gaps and outer gaps cannot have separate left/right/top/bottom configuration. Having your changes will make it faster for me to implement this functionality!

I am very interested to know more about what this functionality can bring to the users and the solutions it can solve, mostly because having separate left/right/top/bottom configuration will confuse some people. Tiling Shell focuses on great UX and ease of use, so I don't want to complicate things unless they are needed

@mmertgunduz
Copy link
Author

mmertgunduz commented Mar 22, 2025

@domferr

I thank you for creating this tool!

This feature will allow us to change them seperately, this will give the chance to configure it same with static top bar and bottom bar in Gnome environments.

That way we can have a good looking tiling-manager like environments.

Let's say we have a desktop environment that has a bar at the top and it has got widgets with fixed margins (gaps).

We can give the same margin to the outer gaps and inner gaps to make it as the same with top bar.

The top bar can have 10 margin to top, 20 margin to left and rights. But with the previous version we couldn't achieve the same margins which would look unoriented.

This was the main issue I faced with when using your lovely extension :)

I think this will allow so many people to rice their Gnome environments to a next level with your tool.

Some other people also bumped the issue I've opened, I think they are also having a common problem.

Thanks! 🚀

@domferr
Copy link
Owner

domferr commented Mar 29, 2025

Thank you @MertGunduz !
Meanwhile I've been working on removing from (almost) everywhere the assumption that gaps are equal, allowing having separate left/right/top/bottom configuration

@mmertgunduz
Copy link
Author

I thank you @domferr!

I'm very excited to build amazing looking and functional GNOME builds with this feature :)

@aisneto
Copy link

aisneto commented May 6, 2025

Just chiming in to support this — top gaps would really help in setups using auto-hide for the top bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Inner Gaps & Outer Gaps would be better if it was customizable for left-right-top-bottom sides.

3 participants