Skip to content

Conversation

TimP4w
Copy link

@TimP4w TimP4w commented Jul 31, 2025

Resolves #353

@TimP4w TimP4w changed the base branch from main to v17.0 July 31, 2025 17:33
@TimP4w TimP4w marked this pull request as draft July 31, 2025 19:27
@TimP4w
Copy link
Author

TimP4w commented Jul 31, 2025

I had a better look. Scrolling wouldn't work with this.

Apparently St.ScrollView does not support touch dragging? Not exactly sure, but i created a minimal example with only a St.ScrollView and it didn't scroll on touch.

So I guess I have to implement it myself. This makes the whole thing less trivial, because now we need to check if it's a tap or a drag, then selectively either propagate or block the event and finally move the scroll by deltaY if it was a drag.

@TimP4w TimP4w marked this pull request as ready for review August 1, 2025 01:06
@TimP4w TimP4w force-pushed the touch-support branch 2 times, most recently from 465c6e1 to 77a57ef Compare August 1, 2025 01:31
@domferr
Copy link
Owner

domferr commented Aug 1, 2025

Hey, thank you so much for your contribution! I have little time to review, but It will be my top priority <3

@domferr domferr force-pushed the v17.0 branch 2 times, most recently from 0266a31 to 8b7dd00 Compare August 1, 2025 19:28
@TimP4w TimP4w force-pushed the touch-support branch 2 times, most recently from 8c15e38 to 5860a7b Compare August 2, 2025 17:11
@domferr domferr changed the base branch from v17.0 to v17.1 October 4, 2025 15:12
@domferr
Copy link
Owner

domferr commented Oct 4, 2025

Changed base branch to v17.1 to aim to get this feature in the upcoming release!

@domferr
Copy link
Owner

domferr commented Oct 5, 2025

Great work, thank you! I have refactored the code, ensuring it works on GNOME versions from 42 to 49. I also improved the strategy, by reacting to touch events instead of emitting button press event (which was failing on GNOME 44).

Unfortunately I cannot test the scrolling on my GNOME 44, since scrollView.vadjustment is not available. If I test with a virtual machine, touch events are propagated as button press/release events and I cannot test properly

@domferr
Copy link
Owner

domferr commented Oct 5, 2025

@TimP4w I will merge this PR, however can you double check everything is working on your side? Thank you!

@TimP4w
Copy link
Author

TimP4w commented Oct 6, 2025

@domferr I'm a bit busy at the moment, but I'll try to test it on my laptop by the end of the week (GNOME 48)

@domferr
Copy link
Owner

domferr commented Oct 17, 2025

Thank you @TimP4w !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add touchscreen support to select window recommendations

2 participants